Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various wave updates: Reformat WW3 inputs; enable PIO for wave restarts; enable WW3 cycling; synchronize UFS restart writes; add uglo_15km WW3 grid #3190
base: develop
Are you sure you want to change the base?
Various wave updates: Reformat WW3 inputs; enable PIO for wave restarts; enable WW3 cycling; synchronize UFS restart writes; add uglo_15km WW3 grid #3190
Changes from 63 commits
54dd21b
5069875
0791f27
dfbdf63
2685096
37ae897
fcc0979
ffea11d
2b33cd5
a3d9b4c
1149faf
67b5f54
c470488
b575ff6
8020fc7
94f9f2a
e3a1bd9
886e638
cf21059
32ec7b2
d5335a1
bdce86f
0ee666d
26a0c42
89225c5
6eb5778
6d5eb04
d526db6
47be8b3
0be2ee2
bcfdd61
0943e5e
b234886
37e5df4
28b5608
6be3977
e10680c
593fe7c
0a8dfa8
83d3baa
69f4998
77a9ed5
a92fe59
5f1c12e
f317180
3e838b7
151d5ee
6de3b03
e940cb6
ed53409
7794784
cea2a52
b1d31ca
7910cbe
c1b6730
9094b60
ce91f63
9955dbd
554b017
aeaa85a
cacbb16
159496e
8971454
4097a37
6741814
d0d4661
4ff02a2
b74305a
77e24e2
b09ddff
b20d9a7
0ab6a40
a4721c0
6ff0ce7
cb97cf6
300c1de
b1b7cd0
521f4d3
cdc5a9c
a381d54
951a117
e889719
49ff12d
84989e6
db8f725
f4c1470
33731e1
bb122da
2cf6350
0271e27
70a62f8
6e7dfef
3e8b9d1
a7cd616
fe1719a
7620805
3290734
fd028e6
7e0e134
b3d881a
8a82fb5
7fa1b76
f5a61ab
8da0472
6e8d24f
1a514f2
184f7d7
596a726
d45edf5
89ff6c8
3113f1c
ae2d144
fd5a3b1
e0ccb09
d7bf8a7
9ffe0f0
3b4479a
5c8e9e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a common variable if it starts w/
cmeps
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you prefer it be called? This is for CMEPS, WW3, ICE, and MOM6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not the name, but the place these are introduced.
The function
CMEPS_predet
IMO, would be appropriate to introduce these variables related tocmeps_
(and more general the coupled model since they share these concepts)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional explanation. I will move it to CMEPS!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!