-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch dev branch up with main #601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
included only pkgs that are dependencies
To make it clear this is an integration test.
by cleaning up the R code Removes functions * mkObj * create_rcpp_interface_object * use_module * %>% * FIMSFrameAge Adds importFrom(TMB, MakeADFun) to package b/c TMB is no longer explicitly used in the codebase. And, experimented with removing usethis b/c it was also used in ./R/ but is still used in data-raw. It is now a suggested package. Uses :: instead of importing functions, e.g., utils::head(). * Constricts line width to 80 characters * Use full stops at the end of sentences * Implement more spacing in between roxygen tags * Move export tag to the end in most instances * Use explicit brackets for if statements * Remove duplicated code in gtest by calling run_gtest() * Parameter and object names to snake_case * Parameter, function, and object names, largely, w/o abbreviations fix(run_gtest): Use paste() instead of paste0() to ensure proper spacing which is not explicit in the instructions. With paste() they can input as many additional arguments as they want and they are all automatically separated, e.g., `run_gtest("--something", "--something-else")` Close #588 Close #564 Close #590
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
I don't think this requires a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge main into dev branch