Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch dev branch up with main #601

Merged
merged 19 commits into from
May 25, 2024
Merged

catch dev branch up with main #601

merged 19 commits into from
May 25, 2024

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    3ce2950 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b37e1ca View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3e5f30 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ba5234 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a7f7336 View commit details
    Browse the repository at this point in the history
  6. fix index value

    ChristineStawitz-NOAA committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    de26e55 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7b32501 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    18f96a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    895d728 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97281c2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    3831941 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. fix [Bug]: Codespace fails to build #559

    included only pkgs that are dependencies
    k-doering-NOAA authored and Andrea-Havron-NOAA committed May 8, 2024
    Configuration menu
    Copy the full SHA
    63e7770 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41a3ab7 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    f32ace1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a3a1ed View commit details
    Browse the repository at this point in the history
  3. rename integration test file

    To make it clear this is an integration test.
    k-doering-NOAA authored and kellijohnson-NOAA committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c090278 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fe5836b View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. refactor (*.R): Adhere to tidyverse principals

    by cleaning up the R code
    
    Removes functions
    * mkObj
    * create_rcpp_interface_object
    * use_module
    * %>%
    * FIMSFrameAge
    
    Adds importFrom(TMB, MakeADFun) to package b/c TMB is no longer
    explicitly used in the codebase. And, experimented with removing usethis
    b/c it was also used in ./R/ but is still used in data-raw. It is now a
    suggested package. Uses :: instead of importing functions, e.g.,
    utils::head().
    
    * Constricts line width to 80 characters
    * Use full stops at the end of sentences
    * Implement more spacing in between roxygen tags
    * Move export tag to the end in most instances
    * Use explicit brackets for if statements
    * Remove duplicated code in gtest by calling run_gtest()
    * Parameter and object names to snake_case
    * Parameter, function, and object names, largely, w/o abbreviations
    
    fix(run_gtest): Use paste() instead of paste0() to ensure proper spacing
    which is not explicit in the instructions. With paste()
    they can input as many additional arguments as they want and they are
    all automatically separated, e.g.,
    `run_gtest("--something", "--something-else")`
    
    Close #588
    Close #564
    Close #590
    MOshima-PIFSC authored and kellijohnson-NOAA committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2431f59 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    288a6ac View commit details
    Browse the repository at this point in the history