Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge DataLinks get_common_strains to ObjectLink #250

Merged
merged 6 commits into from
Jun 10, 2024
Merged

merge DataLinks get_common_strains to ObjectLink #250

merged 6 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. add method intersection to StrainCollection

    @CunliangGeng
    CunliangGeng committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7b53257 View commit details
    Browse the repository at this point in the history

  2. rename shared_strains to common_strains

    @CunliangGeng
    CunliangGeng committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    15f61eb View commit details
    Browse the repository at this point in the history

  3. change common_strains to a property in ObjectLink

    @CunliangGeng
    CunliangGeng committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3afcfd7 View commit details
    Browse the repository at this point in the history

  4. remove useless code for getting common strains 

    now it's very easy to get common strains using the new `StrainCollection.intersection` method
    @CunliangGeng
    CunliangGeng committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    53ba6fd View commit details
    Browse the repository at this point in the history

  5. remove useless unit tests

    @CunliangGeng
    CunliangGeng committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    35f5a88 View commit details
    Browse the repository at this point in the history

  6. remove unused functions that use DataLink

    @CunliangGeng
    CunliangGeng committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    230162e View commit details
    Browse the repository at this point in the history