Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge DataLinks get_common_strains to ObjectLink #250

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented May 31, 2024

As mentioned in last PR #249, the role of DataLinks.get_common_strains is merged to ObjectLink and StrainCollection classes in this PR.

Major changes

  • add method intersection to StrainCollection to compute common strains
  • change common_strains to a property in ObjectLink
  • remove all code of using DataLinks.get_common_strains

@CunliangGeng CunliangGeng requested a review from gcroci2 May 31, 2024 15:39
@CunliangGeng CunliangGeng self-assigned this May 31, 2024
@CunliangGeng CunliangGeng marked this pull request as ready for review May 31, 2024 15:39
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch from 52960e6 to 7ef55a9 Compare June 6, 2024 07:16
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_ObjectLink branch from 7f9f439 to 9711915 Compare June 6, 2024 07:16
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch from 7ef55a9 to be49128 Compare June 6, 2024 07:21
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_ObjectLink branch from 9711915 to 8dade37 Compare June 6, 2024 07:21
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch from be49128 to abdc779 Compare June 6, 2024 07:24
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_ObjectLink branch from 8dade37 to 6674ba0 Compare June 6, 2024 07:24
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_MetcalfScoring branch from abdc779 to 1857d31 Compare June 6, 2024 13:49
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_ObjectLink branch from 6674ba0 to 063ecdc Compare June 6, 2024 13:49
Copy link
Member Author

CunliangGeng commented Jun 10, 2024

Merge activity

  • Jun 10, 3:24 AM EDT: @CunliangGeng started a stack merge that includes this pull request via Graphite.
  • Jun 10, 3:26 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 10, 3:27 AM EDT: @CunliangGeng merged this pull request with Graphite.

Base automatically changed from merge_DataLinks_to_MetcalfScoring to dev June 10, 2024 07:25
@CunliangGeng CunliangGeng force-pushed the merge_DataLinks_to_ObjectLink branch from 063ecdc to 230162e Compare June 10, 2024 07:25
@CunliangGeng CunliangGeng merged commit 3bed728 into dev Jun 10, 2024
1 of 2 checks passed
@CunliangGeng CunliangGeng deleted the merge_DataLinks_to_ObjectLink branch June 10, 2024 07:27
@CunliangGeng CunliangGeng mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants