refactor MetcalfScoring methods #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2024
Merged
This was referenced Jun 7, 2024
6 tasks
CunliangGeng
force-pushed
the
uniform_attribute_name_to_id
branch
from
2be6dce
to
027357a
Compare
CunliangGeng
force-pushed
the
refactor_MetcalfScoring_methods
branch
from
164a0b9
to
fceea81
Compare
This was referenced Jun 10, 2024
Merged
It might lead to inconsistent `npl` if both `__init__` and `setup` take `npl` as parameter.
This method is just a wrapper on `_calc_raw_score` and `_calc_mean_std`. Better to move its code to `setup` method.
- use `cls.npl` - remove setup code from cache
Update metcalf_scoring.py
E.g. use `GCF` instead of `GCF.id` as the index or column of a dataframe. This will skip the steps to look up actual object with a given id.
CunliangGeng
force-pushed
the
refactor_MetcalfScoring_methods
branch
from
fceea81
to
51ad6f1
Compare
gcroci2
reviewed
Jun 14, 2024
gcroci2
approved these changes
Jun 14, 2024
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
|
Merged
Merge activity
|
This was referenced Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring the classes or functions used by scoring methods, now it's time to refactor MetcalfScoring methods.
The basic idea of the refactoring is to simplify the steps of calculating metcalf raw score and standardised score, and try to improve the speed performance of the calculation through e.g. reducing the use of loop and look up.
It's better to review the changes commit by commit, and some commits describe the purpose of the changes.