Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor MetcalfScoring methods #254

Merged
merged 18 commits into from
Jun 14, 2024
Merged

Commits on Jun 13, 2024

  1. update abc.py to change npl to class attribute

    It might lead to inconsistent `npl` if both `__init__` and `setup` take `npl` as parameter.
    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    646ce00 View commit details
    Browse the repository at this point in the history
  2. remove calc_score method

    This method is just a wrapper on `_calc_raw_score` and `_calc_mean_std`.
    Better to move its code to `setup` method.
    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1497fd3 View commit details
    Browse the repository at this point in the history
  3. update setup to use cls.npl

    -  use `cls.npl`
    - remove setup code from cache
    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2f22594 View commit details
    Browse the repository at this point in the history
  4. rename objtype to type

    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    99319c7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e37483e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a883693 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3d06801 View commit details
    Browse the repository at this point in the history
  8. change LINK_TYPES to enum LinkType

    Update metcalf_scoring.py
    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c8f3725 View commit details
    Browse the repository at this point in the history
  9. update _get_links

    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d9142a9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0846f26 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1fbcfe1 View commit details
    Browse the repository at this point in the history
  12. remove unused function

    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    03a0f59 View commit details
    Browse the repository at this point in the history
  13. clean get_links

    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e3d1c6b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3e4c347 View commit details
    Browse the repository at this point in the history
  15. use hashable object itself as index or column of dataframe

    E.g. use `GCF` instead of `GCF.id` as the index or column of a dataframe. This will skip the steps to look up actual object with a given id.
    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    4c7ae5d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7630bf6 View commit details
    Browse the repository at this point in the history
  17. update unit tests

    CunliangGeng committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    51ad6f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Apply suggestions from code review

    Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
    CunliangGeng and gcroci2 authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fb8a6d5 View commit details
    Browse the repository at this point in the history