-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor MetcalfScoring methods #254
Merged
Merged
Commits on Jun 13, 2024
-
update abc.py to change
npl
to class attributeIt might lead to inconsistent `npl` if both `__init__` and `setup` take `npl` as parameter.
Configuration menu - View commit details
-
Copy full SHA for 646ce00 - Browse repository at this point
Copy the full SHA 646ce00View commit details -
This method is just a wrapper on `_calc_raw_score` and `_calc_mean_std`. Better to move its code to `setup` method.
Configuration menu - View commit details
-
Copy full SHA for 1497fd3 - Browse repository at this point
Copy the full SHA 1497fd3View commit details -
- use `cls.npl` - remove setup code from cache
Configuration menu - View commit details
-
Copy full SHA for 2f22594 - Browse repository at this point
Copy the full SHA 2f22594View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99319c7 - Browse repository at this point
Copy the full SHA 99319c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e37483e - Browse repository at this point
Copy the full SHA e37483eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a883693 - Browse repository at this point
Copy the full SHA a883693View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d06801 - Browse repository at this point
Copy the full SHA 3d06801View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8f3725 - Browse repository at this point
Copy the full SHA c8f3725View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9142a9 - Browse repository at this point
Copy the full SHA d9142a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0846f26 - Browse repository at this point
Copy the full SHA 0846f26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fbcfe1 - Browse repository at this point
Copy the full SHA 1fbcfe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03a0f59 - Browse repository at this point
Copy the full SHA 03a0f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3d1c6b - Browse repository at this point
Copy the full SHA e3d1c6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e4c347 - Browse repository at this point
Copy the full SHA 3e4c347View commit details -
use hashable object itself as index or column of dataframe
E.g. use `GCF` instead of `GCF.id` as the index or column of a dataframe. This will skip the steps to look up actual object with a given id.
Configuration menu - View commit details
-
Copy full SHA for 4c7ae5d - Browse repository at this point
Copy the full SHA 4c7ae5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7630bf6 - Browse repository at this point
Copy the full SHA 7630bf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51ad6f1 - Browse repository at this point
Copy the full SHA 51ad6f1View commit details
Commits on Jun 14, 2024
-
Apply suggestions from code review
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fb8a6d5 - Browse repository at this point
Copy the full SHA fb8a6d5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.