Update AdvancedMH.jl wrapper for Monte Carlo sampling. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdvancedMH or one of its dependencies may have updated a keyword from "initial_config" to "initial_params". This caused NQCD to not deliver initial positions to the sampling chain correctly.
- Update ThermalMonteCarlo.jl with new keywords movement_ratio and stop_ratio, where movement_ratio=1-stop_ratio - Add warning for deprecated kwargs. - Update documentation with information about new keywords
This was
linked to
issues
Dec 11, 2023
jamesgardner1421
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd attempt at a PR without merging in extra stuff as well
#320 was caused due to a breaking change in how AdvancedMH.jl handles the init_params keyword. initial_params is now required instead. I've removed compatibility for lower versions of AdvancedMH.jl to be safe.
#321 Has a non-breaking change to the movement-related keywords. Using the old move_ratio and internal_ratio will now produce a warning. Old keywords could be removed entirely after some time.