Fix allocation-based unit tests #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nhertl
reviewed
Apr 8, 2024
Nhertl
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Does this test work when somebody applies an older version than Julia v1.8? I mean, we could state that NQCD requires Julia v1.8 minimum to remedy this. I just wanted to point out, that the if case here does not account for older versions than Julia v1.8 and consequently might break.
|
Good point, I've made it catch-all now. Minimum Julia version enforced at the moment is 1.7. |
Alexsp32
added a commit
that referenced
this pull request
Apr 11, 2024
Alexsp32
added a commit
that referenced
this pull request
Apr 15, 2024
* Stopgap fix for failing unit tests based on memory allocation * Add allocation test debug messages * Fixed version logic to be defined for all Julia versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not particularly proud of this "temporary" fix to the failing tests for
LargeDiabaticCalculatorandRingPolymerLargeDiabaticCalculator, but here we are. Until we decide on a better unit test to replace these ones, we can whitelist different values for different Julia versions.