Fix GHE Bugs

[mitchute]

Pull request overview

• Fixes Problem with GHE Construction from Single BH Objects #10494

This is likely to be a running PR where GHE bug fixes are posted.

Beyond that, we are starting a larger effort to refactor and enhance the E+ GHE model. The bugs, reactors, and features will be trickling in over the next couple of release cycles.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[nrel-bot-2c]

@mitchute @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot]

@mitchute @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-3]

@mitchute @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot]

@mitchute @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot]

@mitchute @Myoldmopar it has been 28 days since this pull request was last updated.

[github-actions]

⚠️ Regressions detected on macos-14 for commit 35eaa5d

Regression Summary

• EIO: 2
• GLHE: 2
• ESO Small Diffs: 2
• Table Big Diffs: 2
• Table String Diffs: 2

• View Results
• Download Regressions

[nrel-bot-2]

@mitchute @Myoldmopar it has been 31 days since this pull request was last updated.

[Myoldmopar]

All clean here, merging this.