Map mobile homes to HPXML's "manufactured home" #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-family detached".
shorowit
commented
Jul 11, 2024
Comment on lines
411
to
413
| # FIXME: Need to disaggregate detached and mobile home | ||
| cfas = { ['0-499', HPXML::ResidentialTypeSFD] => 298, # AHS 2021, 1 detached and mobile home weighted average | ||
| ['0-499', HPXML::ResidentialTypeSFA] => 273, # AHS 2021, 1 detached and mobile home weighted average | ||
| ['0-499', HPXML::ResidentialTypeSFA] => 273, # AHS 2021, 1 attached |
There was a problem hiding this comment.
@joseph-robertson Do you know how to generate new numbers that disaggregate SFD and MH?
There was a problem hiding this comment.
In that case, we can probably keep this PR as is. It makes no substantive changes (no changes to simulation results); it only updates the building type in the HPXML and lays the groundwork for making additional MH-specific changes in the future.
shorowit
commented
Jul 11, 2024
Comment on lines
468
to
479
| if [HPXML::ResidentialTypeSFD].include?(args[:geometry_unit_type]) | ||
| # FIXME: Need to disaggregate detached and mobile home | ||
| if [HPXML::ResidentialTypeSFD, HPXML::ResidentialTypeManufactured].include?(args[:geometry_unit_type]) |
There was a problem hiding this comment.
Probably not worth changing this right now. I'm looking to incorporate these plug load equations into OpenStudio-HPXML, and will separate out SFD and MH there.
There was a problem hiding this comment.
shorowit
changed the title
joseph-robertson
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Maps mobile homes to HPXML using "manufactured home" instead of "single-family detached". Partially addresses #1098.
Checklist
Not all may apply:
Tests (and test files) have been updatedIf related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.Add to the changelog_dev.rst fileopenstudio tasks.rb update_measureshas been run