Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map mobile homes to HPXML's "manufactured home" #1270

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Map mobile homes to HPXML's "manufactured home" #1270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0195938
Maps mobile homes to HPXML using "manufactured home" instead of "sing…
shorowit Jul 11, 2024
88589a2
Latest results.
Jul 12, 2024
9830d39
Change FIXMEs to TODOs. [ci skip]
shorowit Jul 12, 2024
fc79e6c
Merge branch 'mobile_homes' of https://github.com/NREL/resstock into …
shorowit Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions measures/ResStockArguments/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,33 +408,43 @@ def run(model, runner, user_arguments)

# Conditioned floor area
if args[:geometry_unit_cfa] == Constants.Auto
# FIXME: Need to disaggregate detached and mobile home
cfas = { ['0-499', HPXML::ResidentialTypeSFD] => 298, # AHS 2021, 1 detached and mobile home weighted average
['0-499', HPXML::ResidentialTypeSFA] => 273, # AHS 2021, 1 detached and mobile home weighted average
['0-499', HPXML::ResidentialTypeSFA] => 273, # AHS 2021, 1 attached
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-robertson Do you know how to generate new numbers that disaggregate SFD and MH?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not; I believe @afontani did this. But note that we very recently have been discussing modifying this approach with not only a replacement of AHS with RECS, but also some kind of random selection of CFAs within bins. We should probably discuss.

@rajeee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, we can probably keep this PR as is. It makes no substantive changes (no changes to simulation results); it only updates the building type in the HPXML and lays the groundwork for making additional MH-specific changes in the future.

['0-499', HPXML::ResidentialTypeApartment] => 322, # AHS 2021, multi-family weighted average
['0-499', HPXML::ResidentialTypeManufactured] => 298, # AHS 2021, 1 detached and mobile home weighted average
['500-749', HPXML::ResidentialTypeSFD] => 634, # AHS 2021, 1 detached and mobile home weighted average
['500-749', HPXML::ResidentialTypeSFA] => 625, # AHS 2021, 1 attached
['500-749', HPXML::ResidentialTypeApartment] => 623, # AHS 2021, multi-family weighted average
['500-749', HPXML::ResidentialTypeManufactured] => 634, # AHS 2021, 1 detached and mobile home weighted average
['750-999', HPXML::ResidentialTypeSFD] => 881, # AHS 2021, 1 detached and mobile home weighted average
['750-999', HPXML::ResidentialTypeSFA] => 872, # AHS 2021, 1 attached
['750-999', HPXML::ResidentialTypeApartment] => 854, # AHS 2021, multi-family weighted average
['750-999', HPXML::ResidentialTypeManufactured] => 881, # AHS 2021, 1 detached and mobile home weighted average
['1000-1499', HPXML::ResidentialTypeSFD] => 1228, # AHS 2021, 1 detached and mobile home weighted average
['1000-1499', HPXML::ResidentialTypeSFA] => 1207, # AHS 2021, 1 attached
['1000-1499', HPXML::ResidentialTypeApartment] => 1138, # AHS 2021, multi-family weighted average
['1000-1499', HPXML::ResidentialTypeManufactured] => 1228, # AHS 2021, 1 detached and mobile home weighted average
['1500-1999', HPXML::ResidentialTypeSFD] => 1698, # AHS 2021, 1 detached and mobile home weighted average
['1500-1999', HPXML::ResidentialTypeSFA] => 1678, # AHS 2021, 1 attached
['1500-1999', HPXML::ResidentialTypeApartment] => 1682, # AHS 2021, multi-family weighted average
['1500-1999', HPXML::ResidentialTypeManufactured] => 1698, # AHS 2021, 1 detached and mobile home weighted average
['2000-2499', HPXML::ResidentialTypeSFD] => 2179, # AHS 2021, 1 detached and mobile home weighted average
['2000-2499', HPXML::ResidentialTypeSFA] => 2152, # AHS 2021, 1 attached
['2000-2499', HPXML::ResidentialTypeApartment] => 2115, # AHS 2021, multi-family weighted average
['2000-2499', HPXML::ResidentialTypeManufactured] => 2179, # AHS 2021, 1 detached and mobile home weighted average
['2500-2999', HPXML::ResidentialTypeSFD] => 2678, # AHS 2021, 1 detached and mobile home weighted average
['2500-2999', HPXML::ResidentialTypeSFA] => 2663, # AHS 2021, 1 attached
['2500-2999', HPXML::ResidentialTypeApartment] => 2648, # AHS 2021, multi-family weighted average
['2500-2999', HPXML::ResidentialTypeManufactured] => 2678, # AHS 2021, 1 detached and mobile home weighted average
['3000-3999', HPXML::ResidentialTypeSFD] => 3310, # AHS 2021, 1 detached and mobile home weighted average
['3000-3999', HPXML::ResidentialTypeSFA] => 3228, # AHS 2021, 1 attached
['3000-3999', HPXML::ResidentialTypeApartment] => 3171, # AHS 2021, multi-family weighted average
['3000-3999', HPXML::ResidentialTypeManufactured] => 3310, # AHS 2021, 1 detached and mobile home weighted average
['4000+', HPXML::ResidentialTypeSFD] => 5587, # AHS 2021, 1 detached and mobile home weighted average
['4000+', HPXML::ResidentialTypeSFA] => 7414, # AHS 2019, 1 attached
['4000+', HPXML::ResidentialTypeApartment] => 6348 } # AHS 2021, 4,000 or more all unit average
['4000+', HPXML::ResidentialTypeApartment] => 6348, # AHS 2021, 4,000 or more all unit average
['4000+', HPXML::ResidentialTypeManufactured] => 5587 } # AHS 2021, 1 detached and mobile home weighted average
cfa = cfas[[args[:geometry_unit_cfa_bin], args[:geometry_unit_type]]]
if cfa.nil?
runner.registerError("ResStockArguments: Could not look up conditioned floor area for '#{args[:geometry_unit_cfa_bin]}' and '#{args[:geometry_unit_type]}'.")
Expand Down Expand Up @@ -465,7 +475,8 @@ def run(model, runner, user_arguments)

# Other
if args[:misc_plug_loads_other_annual_kwh].to_s == Constants.Auto
if [HPXML::ResidentialTypeSFD].include?(args[:geometry_unit_type])
# FIXME: Need to disaggregate detached and mobile home
if [HPXML::ResidentialTypeSFD, HPXML::ResidentialTypeManufactured].include?(args[:geometry_unit_type])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth changing this right now. I'm looking to incorporate these plug load equations into OpenStudio-HPXML, and will separate out SFD and MH there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NREL/OpenStudio-HPXML#1775

args[:misc_plug_loads_other_annual_kwh] = 863.26 + 219.26 * args[:geometry_unit_num_occupants] + 0.33 * args[:geometry_unit_cfa] # RECS 2020
elsif [HPXML::ResidentialTypeSFA].include?(args[:geometry_unit_type])
args[:misc_plug_loads_other_annual_kwh] = 654.92 + 206.52 * args[:geometry_unit_num_occupants] + 0.21 * args[:geometry_unit_cfa] # RECS 2020
Expand Down
6 changes: 3 additions & 3 deletions measures/ResStockArguments/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>res_stock_arguments</name>
<uid>c984bb9e-4ac4-4930-a399-9d23f8f6936a</uid>
<version_id>d38cd429-d4e6-495c-a421-8f06b2391798</version_id>
<version_modified>2024-06-21T02:11:37Z</version_modified>
<version_id>1c72228d-9e8d-4b2b-9f0a-7808a8425f2c</version_id>
<version_modified>2024-07-11T22:05:34Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>ResStockArguments</class_name>
<display_name>ResStock Arguments</display_name>
Expand Down Expand Up @@ -7497,7 +7497,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>96F4DFC0</checksum>
<checksum>F1A6AC1F</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down
2 changes: 1 addition & 1 deletion resources/options_lookup.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9361,7 +9361,7 @@ Geometry Building Type Height Mobile Home
Geometry Building Type Height Multifamily with 2-4 Units
Geometry Building Type Height Single-Family Attached
Geometry Building Type Height Single-Family Detached
Geometry Building Type RECS Mobile Home ResStockArguments geometry_unit_type=single-family detached geometry_average_ceiling_height=8 geometry_unit_aspect_ratio=1.8
Geometry Building Type RECS Mobile Home ResStockArguments geometry_unit_type=manufactured home geometry_average_ceiling_height=8 geometry_unit_aspect_ratio=1.8
Geometry Building Type RECS Multi-Family with 2 - 4 Units ResStockArguments geometry_unit_type=apartment unit geometry_average_ceiling_height=8 geometry_unit_aspect_ratio=0.5556
Geometry Building Type RECS Multi-Family with 5+ Units ResStockArguments geometry_unit_type=apartment unit geometry_average_ceiling_height=8 geometry_unit_aspect_ratio=0.5556
Geometry Building Type RECS Single-Family Attached ResStockArguments geometry_unit_type=single-family attached geometry_average_ceiling_height=8 geometry_unit_aspect_ratio=0.5556
Expand Down