Fix overlapping memcpy in t1oi2c library #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phNxpEseProro7816_SaveRxframeData() makes memcpy() calls with
overlapping source/destination ranges. ASAN catches it immediately:
ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0xfffffffff609,0xfffffffff612) and [0xfffffffff60c, 0xfffffffff615) overlap
#0 0xfffff789bd84 in __interceptor_memcpy /data/jenkins/workspace/GNU-toolchain/arm-12/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827
NXPPlugNTrust#1 0x448d7c in phNxpEse_memcpy (/root/nano_package_test+0x448d7c)
NXPPlugNTrust#2 0x44a104 in phNxpEseProro7816_SaveRxframeData (/root/nano_package_test+0x44a104)
NXPPlugNTrust#3 0x44a410 in phNxpEseProto7816_DecodeFrame (/root/nano_package_test+0x44a410)
NXPPlugNTrust#4 0x44aea0 in phNxpEseProto7816_ProcessResponse (/root/nano_package_test+0x44aea0)
NXPPlugNTrust#5 0x44b1dc in TransceiveProcess (/root/nano_package_test+0x44b1dc)
NXPPlugNTrust#6 0x44b2a4 in phNxpEseProto7816_Transceive (/root/nano_package_test+0x44b2a4)
NXPPlugNTrust#7 0x44852c in phNxpEse_Transceive (/root/nano_package_test+0x44852c)
#8 0x4477f4 in smComT1oI2C_TransceiveRaw (/root/nano_package_test+0x4477f4)
#9 0x4412a4 in Se05x_API_SessionOpen (/root/nano_package_test+0x4412a4)
Because memcpy() corrupts data when the source/destination improperly
overlap, fix by replacing the offending memcpy() with memmove().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phNxpEseProro7816_SaveRxframeData() makes memcpy() calls with overlapping source/destination ranges. ASAN catches it immediately:
Because memcpy() corrupts data when the source/destination improperly overlap, fix by replacing the offending memcpy() with memmove().