Commits on Sep 18, 2024

1. Fix overlapping memcpy in t1oi2c library …

   phNxpEseProro7816_SaveRxframeData() makes memcpy() calls with
   overlapping source/destination ranges. ASAN catches it immediately:
   
       ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0xfffffffff609,0xfffffffff612) and [0xfffffffff60c, 0xfffffffff615) overlap
       #0 0xfffff789bd84 in __interceptor_memcpy /data/jenkins/workspace/GNU-toolchain/arm-12/src/gcc/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827
       NXPPlugNTrust#1 0x448d7c in phNxpEse_memcpy (/root/nano_package_test+0x448d7c)
       NXPPlugNTrust#2 0x44a104 in phNxpEseProro7816_SaveRxframeData (/root/nano_package_test+0x44a104)
       NXPPlugNTrust#3 0x44a410 in phNxpEseProto7816_DecodeFrame (/root/nano_package_test+0x44a410)
       NXPPlugNTrust#4 0x44aea0 in phNxpEseProto7816_ProcessResponse (/root/nano_package_test+0x44aea0)
       NXPPlugNTrust#5 0x44b1dc in TransceiveProcess (/root/nano_package_test+0x44b1dc)
       NXPPlugNTrust#6 0x44b2a4 in phNxpEseProto7816_Transceive (/root/nano_package_test+0x44b2a4)
       NXPPlugNTrust#7 0x44852c in phNxpEse_Transceive (/root/nano_package_test+0x44852c)
       #8 0x4477f4 in smComT1oI2C_TransceiveRaw (/root/nano_package_test+0x4477f4)
       #9 0x4412a4 in Se05x_API_SessionOpen (/root/nano_package_test+0x4412a4)
   
   Because memcpy() corrupts data when the source/destination improperly
   overlap, fix by replacing the offending memcpy() with memmove().

   

   calvin-quilt committed Sep 18, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 27de5d3
   • Browse repository at this point

   Copy the full SHA

   27de5d3 View commit details

   Browse the repository at this point in the history