Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current error handling with "empty record" error handling #361

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

nnansters
Copy link
Contributor

Deal with metric failures by gracefully returning an "empty record".

This will be represented in the results as a row for a certain chunk for which the metric value and any derived values from that will be empty.
Chunk metadata, thresholds and non-failing metrics will still be present.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Comparison is base (d1a70ea) 80.06% compared to head (4343ee5) 79.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
...nyml/performance_calculation/metrics/regression.py 2.70% 24 Missing and 12 partials ⚠️
...e_calculation/metrics/multiclass_classification.py 0.00% 18 Missing and 8 partials ⚠️
...performance_estimation/confidence_based/metrics.py 45.94% 20 Missing ⚠️
...mance_calculation/metrics/binary_classification.py 57.14% 10 Missing and 5 partials ⚠️
...rformance_estimation/direct_loss_estimation/dle.py 54.16% 9 Missing and 2 partials ⚠️
nannyml/performance_calculation/metrics/base.py 52.94% 8 Missing ⚠️
nannyml/drift/univariate/calculator.py 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   80.06%   79.33%   -0.73%     
==========================================
  Files         107      107              
  Lines        7964     8042      +78     
  Branches     1446     1463      +17     
==========================================
+ Hits         6376     6380       +4     
- Misses       1264     1323      +59     
- Partials      324      339      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters marked this pull request as ready for review February 12, 2024 15:53
@nnansters nnansters requested a review from nikml as a code owner February 12, 2024 15:53
@nnansters nnansters merged commit 59fc796 into main Feb 12, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant