Unify Annual Output Table Init Values

[mitchute]

Pull request overview

-This may fix an issue related to the annual output table initial values.

Description of the purpose of this PR

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
• If adding/removing any output files (e.g., eplustbl.*)
  • Update ..\scripts\Epl-run.bat
  • Update ..\scripts\RunEPlus.bat
  • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
  • Update ...github\workflows\energyplus.py

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mitchute]

There's a discrepeancy between std::numeric_limits<Real64>::min() and what it looks like the intent was here. See compiler explorer for an example, as well as the docs for numeric_limits.

Making this change resulted in the following diff for an annual simulation in PurchAir_wAnnual.

Current develop.

Updated branch.

I would be curious of your thoughts on this @JasonGlazer.

[JasonGlazer]

@mitchute that looks good. No reason the minimum number should have ever appeared in a report, it should have always just been a blank in that situation.

[mitchute]

Thanks, @JasonGlazer

[rraustad]

The diffs look like this change corrected an issue where an initialized min did not conform to the test used to report the value. In PurchAirTables_wAnnual there are no Lights in the West zone so that cell should have been blank, and now it is.

[mitchute]

Thanks @rraustad and @JasonGlazer. Merging.