Skip to content

Fix missing zone volume in Engineering Reference C_z definition#11424

Merged
mitchute merged 1 commit intodevelopfrom
11418_eng_reference_eq
Feb 19, 2026
Merged

Fix missing zone volume in Engineering Reference C_z definition#11424
mitchute merged 1 commit intodevelopfrom
11418_eng_reference_eq

Conversation

@brianlball
Copy link
Contributor

Fixes #11418

Add missing zone volume (V_z) term to Engineering Reference Equation 2.1 definition of C_z.

The definition was ρ_air × C_p × C_T (units: J/°C·m³). Correct definition is V_z × ρ_air × C_p × C_T (units: J/°C),
matching the code in ZoneTempPredictorCorrector.cc.

Documentation-only change — no code or simulation impact.

  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

Fixes #11418

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brianlball brianlball added the Documentation Related primarily on the LaTeX-based EnergyPlus documentation label Feb 19, 2026
@brianlball brianlball added the Defect Includes code to repair a defect in EnergyPlus label Feb 19, 2026
@brianlball
Copy link
Contributor Author

existing docs

image

C\(_{z}\) = $\rho$\(_{air}\)C\(_{p}\)C\(_{T}\)
C\(_{z}\) = $V_{z}$$\rho$\(_{air}\)C\(_{p}\)C\(_{T}\)

\(V_{z}\) = zone air volume
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look correct to me. The right hand side is Watts. So left hand side is Cz = J/C and dTz/dt = C/s, so J/s = W.

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rraustad !

@brianlball
Copy link
Contributor Author

after the fix

2026-02-19_13-29-06

@brianlball brianlball removed the Defect Includes code to repair a defect in EnergyPlus label Feb 19, 2026
@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Feb 19, 2026
@mitchute
Copy link
Collaborator

Where's your unit test... tsk tsk... 😄 jk. Merging.

@mitchute mitchute merged commit fb18757 into develop Feb 19, 2026
11 of 15 checks passed
@mitchute mitchute deleted the 11418_eng_reference_eq branch February 19, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Engineering Reference Equation 2.1

4 participants