-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TokenConfig and add JWT models #2
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2a74456
Add BaseModel for JWT and `HanaToken` (to use for auth and refresh)
NeonDaniel e9be412
Update TokenConfig to better accept alternate named parameters with c…
NeonDaniel ad5ff48
Remove aliased params in `HanaToken` class
NeonDaniel 52663fa
Fix syntax error in annotated fields
NeonDaniel d010958
Update token timestamp descriptions for accuracy
NeonDaniel 2929b62
Update TokenConfig to handle JWT standard field names
NeonDaniel da6b79f
Update comment in TokenConfig
NeonDaniel cd507ae
Mark `TokenConfig` as deprecated
NeonDaniel a05822c
Update tests to reflect changes to `HanaToken`
NeonDaniel f60cd6c
Update token to include initial creation timestamp for database use
NeonDaniel 39d8d7e
Update deprecation warning to use builtin decorator
NeonDaniel 278b2eb
Update JWT base model to remove default values causing false positive…
NeonDaniel 0b55647
Add jwt imports to api module for consistency with other submodules
NeonDaniel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
# NEON AI (TM) SOFTWARE, Software Development Kit & Application Development System | ||
# All trademark and other rights reserved by their respective owners | ||
# Copyright 2008-2024 Neongecko.com Inc. | ||
# BSD-3 | ||
# Redistribution and use in source and binary forms, with or without | ||
# modification, are permitted provided that the following conditions are met: | ||
# 1. Redistributions of source code must retain the above copyright notice, | ||
# this list of conditions and the following disclaimer. | ||
# 2. Redistributions in binary form must reproduce the above copyright notice, | ||
# this list of conditions and the following disclaimer in the documentation | ||
# and/or other materials provided with the distribution. | ||
# 3. Neither the name of the copyright holder nor the names of its | ||
# contributors may be used to endorse or promote products derived from this | ||
# software without specific prior written permission. | ||
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR | ||
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, | ||
# OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF | ||
# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING | ||
# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
||
from time import time | ||
from typing import Optional, List, Literal | ||
from uuid import uuid4 | ||
|
||
from pydantic import Field | ||
from neon_data_models.enum import AccessRoles | ||
from neon_data_models.models.base import BaseModel | ||
|
||
|
||
class JWT(BaseModel): | ||
iss: Optional[str] = Field(None, validate_default=True, | ||
description="Token issuer") | ||
sub: Optional[str] = Field(None, validate_default=True, | ||
description="Unique token subject, ie a user ID") | ||
exp: int = Field(description="Expiration time in epoch seconds") | ||
iat: int = Field(description="Token creation time in epoch seconds") | ||
jti: str = Field(description="Unique token identifier", | ||
default_factory=lambda: str(uuid4())) | ||
|
||
client_id: str = Field(description="Client identifier") | ||
roles: List[str] = Field(description="List of roles, " | ||
"formatted as `<name> <AccessRole>`. " | ||
"See PermissionsConfig for role names") | ||
|
||
|
||
class HanaToken(JWT): | ||
def __init__(self, **kwargs): | ||
from neon_data_models.models.user import PermissionsConfig | ||
permissions = kwargs.get("permissions") | ||
if permissions and isinstance(permissions, PermissionsConfig): | ||
kwargs["roles"] = permissions.to_roles() | ||
elif permissions and isinstance(permissions, dict): | ||
core_permissions = AccessRoles.GUEST if \ | ||
permissions.get("assist") else AccessRoles.NONE | ||
diana_permissions = AccessRoles.GUEST if \ | ||
permissions.get("backend") else AccessRoles.NONE | ||
node_permissions = AccessRoles.USER if \ | ||
permissions.get("node") else AccessRoles.NONE | ||
kwargs["roles"] = [f"core {core_permissions.value}", | ||
f"diana {diana_permissions.value}", | ||
f"node {node_permissions.value}"] | ||
if kwargs.get("expire") and isinstance(kwargs["expire"], float): | ||
kwargs["expire"] = round(kwargs["expire"]) | ||
BaseModel.__init__(self, **kwargs) | ||
|
||
# Private parameters | ||
token_name: str = Field(default="", | ||
description="Friendly name to identify this token.") | ||
creation_timestamp: int = Field(default_factory=lambda: int(time()), | ||
description="Timestamp of initial token " | ||
"creation (not counting " | ||
"refreshes).") | ||
last_refresh_timestamp: Optional[int] = Field(default=None, | ||
description="Timestamp of " | ||
"most recent " | ||
"refresh.") | ||
purpose: Literal["access", "refresh"] = "access" | ||
|
||
|
||
__all__ = [JWT.__name__, HanaToken.__name__] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 seems like a fairly small number, might want to consider something larger like 50 or 100 for "unlimited access". Food for thought, since you haven't defined it here it's not necessarily relevant for this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering that too.. My main concern is that a very large range could make troubleshooting permissions more complicated, though restricting it to enumerated values does obviate that for the most part