Update TokenConfig and add JWT models #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update TokenConfig model to reflect expected database schema Refactor AccessRoles values to allow for more in-between values Add methods to read/dump PermissionsConfig to JWT-compatible role strings
…omment Update unit test to account for token config change
NeonDaniel
commented
Nov 6, 2024
Add test coverage for TokenConfig
NeonDaniel
commented
Nov 7, 2024
|
After some integration testing, having separate |
Refactor `HanaToken` to include params previously used in `TokenConfig`
Annotate fields of HanaToken
… validation results Update unit tests to account for token changes
mikejgray
approved these changes
Nov 18, 2024
| ADMIN = 6 | ||
| # 7-8 Reserved for "restricted owners" | ||
| OWNER = 9 | ||
| # 10 Reserved for "unlimited access" |
There was a problem hiding this comment.
10 seems like a fairly small number, might want to consider something larger like 50 or 100 for "unlimited access". Food for thought, since you haven't defined it here it's not necessarily relevant for this PR
There was a problem hiding this comment.
I was considering that too.. My main concern is that a very large range could make troubleshooting permissions more complicated, though restricting it to enumerated values does obviate that for the most part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add BaseModel for JWT and
HanaToken(to use for auth and refresh)Update TokenConfig model to reflect expected database schema
Refactor AccessRoles values to allow for more in-between values
Add methods to read/dump PermissionsConfig to JWT-compatible role strings
Issues
Relates to NeonGeckoCom/neon-hana#33
Other Notes
This includes a breaking change to
TokenConfigwhich has yet to be implemented anywhere; this change establishes the configuration that will be written to user databasesThis includes a potentially breaking change to
AccessRoles. If used as documented, this change will not affect behavior