Define data models for LLM interactions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
commented
Nov 15, 2024
Defines LLMPersona from backend implementation Defines LLMRequest based on HANA and BrainForge implementations
Define `llm.__all__` and add submodule-level import for consistency
Add support for arbitrary `role` values in `to_completion_kwargs` Add `MqLlmRequest` model with test coverage
Update LLMPersona to be compatible with model in `neon-llm-core` Refactor `MqLlmRequest` to `LLMProposeRequest` to be consistent with Chatbotsforum terminology
NeonDaniel
force-pushed
the
FEAT_LLMRequestModels
branch
from
20c4853 to
7940b24
Compare
…values are compatible
…t the same as what are commonly used in OpenAI requests
NeonBohdan
reviewed
Dec 16, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
reviewed
Dec 17, 2024
|
Consider adding |
Update unit test per review
NeonBohdan
reviewed
Dec 17, 2024
NeonBohdan
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
llmmoduleDefines LLMPersona from backend implementation
Defines LLMRequest based on HANA and BrainForge implementations
Defines MQ API for LLM interactions
Issues
Other Notes
This is compatible with the current implementation in HANA, but it will reformat requests st history follows the OpenAI format
This implements some logic in the BrainForge webapp demo, adding some validation of parameters
This includes some refactoring of module init to resolve circular import/partial-init errors