Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect if ioloop fails to get started #106

Closed
wants to merge 2 commits into from

Conversation

NeonKirill
Copy link
Collaborator

Description

When connecting to RabbitMQ using SelectConsumer, sometimes ioloop connection drops, although becomes successful after reconnecting, idea is to make a reconnection request in such cases instead of forcing disconnect

@NeonKirill NeonKirill requested a review from NeonDaniel January 2, 2025 18:30
LOG.error(f"Failed to start io loop on consumer thread {self.name!r}: {e}")
self._close_connection()
LOG.error(f"Failed to start io loop on consumer thread {self.name!r}: {e}, reconnecting")
self.reconnect()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will recursively call run. This can lead to a Maximum Recursion Error after some amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants