buildDotnetModule: inherit enableParallelBuilding #339335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change, enableParallelBuilding defaults to true for packages
using buildDotnetModule. The argument value already defaults to true,
but we did not use it. Note that default values in Nix are not present
in the arguments attribute set, e.g. `args` does not contain `def` for
`{ def ? true }@Args: …` function unless this argument is explicitly
passed.
|
Result of 1 package marked as broken and skipped:
4 packages failed to build:
66 packages built:
|
|
Result of 1 package marked as broken and skipped:
70 packages built:
|
ofborg
bot
requested review from
l0b0,
josephst,
artemist,
MattSturgeon,
06kellyjac and
aldoborrero
corngood
approved these changes
Sep 4, 2024
MattSturgeon
approved these changes
Sep 4, 2024
| @@ -25,6 +25,8 @@ buildDotnetModule (finalAttrs: { | |||
| hash = "sha256-FzQphMhiC1g+6qmk/R1v4rq2ldy35NcaWm0RR1UlwLA="; | |||
| }; | |||
|
|
|||
| enableParallelBuilding = false; | |||
There was a problem hiding this comment.
I assume you tried to build in parallel but it failed?
There was a problem hiding this comment.
It was in the first nixpkgs-review, on aarch64-linux. Something we should look into.
|
Result of 2 packages marked as broken and skipped:
45 packages built:
|
|
Result of 93 packages built:
|
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After this change, enableParallelBuilding defaults to true for packages using buildDotnetModule. The argument value already defaults to true, but we did not use it. Note that default values in Nix are not present in the arguments attribute set, e.g.
argsdoes not containdeffor{ def ? true }@args: …function unless this argument is explicitly passed.References:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.