Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildDotnetModule: inherit enableParallelBuilding #339335

Merged
merged 4 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/build-support/dotnet/build-dotnet-module/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ let
dotnetUseAppHost = useAppHost;
inherit useDotnetFromEnv;

inherit enableParallelBuilding;

nativeBuildInputs = args.nativeBuildInputs or [ ] ++ [
dotnetConfigureHook
dotnetBuildHook
Expand Down
2 changes: 2 additions & 0 deletions pkgs/by-name/ne/nexusmods-app/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ buildDotnetModule (finalAttrs: {
hash = "sha256-FzQphMhiC1g+6qmk/R1v4rq2ldy35NcaWm0RR1UlwLA=";
};

enableParallelBuilding = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tried to build in parallel but it failed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in the first nixpkgs-review, on aarch64-linux. Something we should look into.


# If the whole solution is published, there seems to be a race condition where
# it will sometimes publish the wrong version of a dependent assembly, for
# example: Microsoft.Extensions.Hosting.dll 6.0.0 instead of 8.0.0.
Expand Down
2 changes: 2 additions & 0 deletions pkgs/by-name/re/recyclarr/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ buildDotnetModule (finalAttrs: {
'';
patches = [ ./001-Git-Version.patch ];

enableParallelBuilding = false;

dotnetRestoreFlags = [ "--configfile=${nuget-config}" ];

doCheck = false;
Expand Down
2 changes: 2 additions & 0 deletions pkgs/by-name/ry/ryujinx/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ buildDotnetModule rec {
sha256 = "1v8j9l2r9sz9s3jhakr3rc50hf6fbdr5cqdrjidjwvziykfckizk";
};

enableParallelBuilding = false;

dotnet-sdk = dotnetCorePackages.sdk_8_0;
dotnet-runtime = dotnetCorePackages.runtime_8_0;

Expand Down