Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.neurokit2: init at 0.2.10 and python312Packages.biosppy: init at 2.2.2 #371449

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

genga898
Copy link
Contributor

@genga898 genga898 commented Jan 6, 2025

Closes #371375

Add neurokit2 and biosppy

Tests for neurokit get stuck on the second test, have been trying to build it for couple of hours, hence the omission of the test checks, was not able to determine if all the tests pass or fail.

Biosppy is a dependency of the neurokit python lib.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in PR title: should be neurokit2.

After addressing these remaining issues, lease rewrite your commits so that one addresses biosppy and one addresses neurokit2.

I think it should be possible to enable the neurokit2 tests, potentially disabling one if it's hanging, although mne is broken right now; see #370107.

pkgs/development/python-modules/biosppy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/biosppy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/neurokit2/default.nix Outdated Show resolved Hide resolved
@genga898 genga898 changed the title python3Packages.neurotkit2: init at 0.2.10 and python3Packages.biosppy: init at 2.2.2 python3Packages.neurokit2: init at 0.2.10 and python3Packages.biosppy: init at 2.2.2 Jan 8, 2025
@genga898
Copy link
Contributor Author

genga898 commented Jan 8, 2025

Typo in PR title: should be neurokit2.

After addressing these remaining issues, lease rewrite your commits so that one addresses biosppy and one addresses neurokit2.

I think it should be possible to enable the neurokit2 tests, potentially disabling one if it's hanging, although mne is broken right now; see #370107.

I got the tests to work by disabling the failing ones and the one that was causing it to get stuck, the one's that pass do not meet the 50% mark, only at 22% meaning the build still fails

Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks almost ready to go!

@genga898 genga898 force-pushed the neurokit-init branch 2 times, most recently from b010b48 to 2275b2b Compare January 9, 2025 11:22
@genga898 genga898 changed the title python3Packages.neurokit2: init at 0.2.10 and python3Packages.biosppy: init at 2.2.2 python312Packages.neurokit2: init at 0.2.10 and python312Packages.biosppy: init at 2.2.2 Jan 9, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 9, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371449


x86_64-linux

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

x86_64-darwin

❌ 8 packages failed to build:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

aarch64-darwin

❌ 8 packages failed to build:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

@GaetanLepage
Copy link
Contributor

Failing on darwin with:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/8zc3wcplydp8gsxms24scpzdca438dk5-python3-3.12.8/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 999, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/z21xzks0wrcxmz6xgx1pijzqiadi1k69-python3.12-biosppy-2.2.2/lib/python3.12/site-packages/biosppy/inter_plotting/__init__.py", line 18, in <module>
    from . import ecg, acc
  File "/nix/store/z21xzks0wrcxmz6xgx1pijzqiadi1k69-python3.12-biosppy-2.2.2/lib/python3.12/site-packages/biosppy/inter_plotting/ecg.py", line 20, in <module>
    from tkinter import *
  File "/nix/store/8zc3wcplydp8gsxms24scpzdca438dk5-python3-3.12.8/lib/python3.12/tkinter/__init__.py", line 38, in <module>
    import _tkinter # If this fails your Python may not be configured for Tk
    ^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_tkinter'

@genga898
Copy link
Contributor Author

Failing on darwin with:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/8zc3wcplydp8gsxms24scpzdca438dk5-python3-3.12.8/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 999, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/z21xzks0wrcxmz6xgx1pijzqiadi1k69-python3.12-biosppy-2.2.2/lib/python3.12/site-packages/biosppy/inter_plotting/__init__.py", line 18, in <module>
    from . import ecg, acc
  File "/nix/store/z21xzks0wrcxmz6xgx1pijzqiadi1k69-python3.12-biosppy-2.2.2/lib/python3.12/site-packages/biosppy/inter_plotting/ecg.py", line 20, in <module>
    from tkinter import *
  File "/nix/store/8zc3wcplydp8gsxms24scpzdca438dk5-python3-3.12.8/lib/python3.12/tkinter/__init__.py", line 38, in <module>
    import _tkinter # If this fails your Python may not be configured for Tk
    ^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_tkinter'

I could add it as an optional dependency on darwin builds but I don't have a machine to test for other failures

@GaetanLepage
Copy link
Contributor

I could add it as an optional dependency on darwin builds but I don't have a machine to test for other failures

Give it a try, I can test it for you.
If it still doesn't work, we can add:

  badPlatforms = [
    lib.systems.inspect.patterns.isDarwin
  ];

@genga898
Copy link
Contributor Author

I could add it as an optional dependency on darwin builds but I don't have a machine to test for other failures

Give it a try, I can test it for you. If it still doesn't work, we can add:

  badPlatforms = [
    lib.systems.inspect.patterns.isDarwin
  ];

Just pushed an update, let me know if it works then I clean up my commit tree

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371449


x86_64-linux

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

x86_64-darwin

❌ 4 packages failed to build:
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist
✅ 4 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist

aarch64-darwin

❌ 4 packages failed to build:
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist
✅ 4 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist

@GaetanLepage
Copy link
Contributor

So, it has helped. Now a test is crashing in neurokit. Let me see which one it is.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371449


x86_64-linux

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

x86_64-darwin

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

aarch64-darwin

✅ 8 packages built:
  • python312Packages.biosppy
  • python312Packages.biosppy.dist
  • python312Packages.neurokit2
  • python312Packages.neurokit2.dist
  • python313Packages.biosppy
  • python313Packages.biosppy.dist
  • python313Packages.neurokit2
  • python313Packages.neurokit2.dist

@genga898
Copy link
Contributor Author

Ok let me fix my commit tree

@GaetanLepage GaetanLepage merged commit 28e627b into NixOS:master Jan 15, 2025
24 of 27 checks passed
@genga898 genga898 deleted the neurokit-init branch January 15, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: python3Packages.neurokit2
5 participants