-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.neurokit2: init at 0.2.10 and python312Packages.biosppy: init at 2.2.2 #371449
Conversation
f6f91cf
to
16d3360
Compare
16d3360
to
cc25924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in PR title: should be neurokit2
.
After addressing these remaining issues, lease rewrite your commits so that one addresses biosppy and one addresses neurokit2.
I think it should be possible to enable the neurokit2 tests, potentially disabling one if it's hanging, although mne
is broken right now; see #370107.
I got the tests to work by disabling the failing ones and the one that was causing it to get stuck, the one's that pass do not meet the 50% mark, only at 22% meaning the build still fails |
cc25924
to
a66a527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks almost ready to go!
b010b48
to
2275b2b
Compare
2275b2b
to
7a540d8
Compare
7a540d8
to
6ce595f
Compare
|
Failing on darwin with:
|
I could add it as an optional dependency on darwin builds but I don't have a machine to test for other failures |
Give it a try, I can test it for you. badPlatforms = [
lib.systems.inspect.patterns.isDarwin
]; |
6ce595f
to
6fb1941
Compare
Just pushed an update, let me know if it works then I clean up my commit tree |
|
So, it has helped. Now a test is crashing in |
|
Ok let me fix my commit tree |
2ac8d84
to
81af874
Compare
Closes #371375
Add neurokit2 and biosppy
Tests for neurokit get stuck on the second test, have been trying to build it for couple of hours, hence the omission of the test checks, was not able to determine if all the tests pass or fail.
Biosppy is a dependency of the neurokit python lib.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.