Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Browser Freezes When Using P2P with Shaka Player on Long Live Streams #454

Merged
merged 13 commits into from
Jan 20, 2025
Merged

Fix: Browser Freezes When Using P2P with Shaka Player on Long Live Streams #454

merged 13 commits into from
Jan 20, 2025

Conversation

DimaDemchenko
Copy link
Contributor

@DimaDemchenko DimaDemchenko commented Jan 17, 2025 •
edited
Loading

closes #448

@DimaDemchenko DimaDemchenko requested a review from mrlika January 17, 2025 14:18
mrlika
mrlika requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@mrlika mrlika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Test with MPEG-DASH
  • getNumEvicted shift should be used for all the get operations by index

@DimaDemchenko DimaDemchenko requested a review from mrlika January 20, 2025 12:57
@mrlika mrlika merged commit 5c0d97a into main Jan 20, 2025
3 checks passed
@mrlika mrlika deleted the fix/browser-freezes-when-using-shaka-on-long-live-streams branch January 20, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrlika mrlika mrlika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser Freezes When Using P2P with Shaka Player on Long Live Streams
2 participants
@DimaDemchenko @mrlika