Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] agreement: Migration to 17.0 #35

Merged
merged 19 commits into from
Sep 24, 2024

Conversation

ramiadavid
Copy link

No description provided.

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration agreement

@rousseldenis
Copy link
Sponsor Contributor

/ocabot rebase

ygol and others added 18 commits September 10, 2024 06:51
we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
- The `agreement` model now features mail and activities from its base module.
- The `agreement_legal` module doesn't need to add mail support now.
- Add activities to form views.

@Tecnativa TT22477
Update agreement and agreement_sale to restore the behavior of v10
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 17.0.

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

agreement/models/agreement.py Outdated Show resolved Hide resolved
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just waiting for the change suggested @ramiadavid

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Co-authored-by: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>
@max3903
Copy link
Sponsor Member

max3903 commented Sep 21, 2024

/ocabot merge nobump

1 similar comment
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-35-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 368bafb into OCA:17.0 Sep 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7a74f0c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.