[14.0][FIX] storage_thumbnail: always use slugified url_key #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
force-pushed
the
14-fix-storage_thumbnail
branch
2 times, most recently
from
8425a21
to
494efd7
Compare
simahawk
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
LG.
@sebastienbeau @lmignon warning for your existing instance.
We've got tons of duplicated thumbs after pulling in #268 😉
Both for creating and searching thumbnails. This avoid an infinite creation of thumbnails on images as soon as an `url_key` is provided. This is a regression introduced by commit 1976597
sebalix
force-pushed
the
14-fix-storage_thumbnail
branch
from
494efd7
to
66567fe
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1692a17. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both for creating and searching thumbnails.
This avoid an infinite creation of thumbnails on images as soon as an
url_keyis provided.This is a regression introduced by commit 1976597
Ref. 4622