[16.0][FIX] hr_timesheet_name_customer: better impl with compute #744
Conversation
Before this commit, the creation would fail when no 'name' value was provided.
|
Hi @solo4games, @CetmixGitDrone, |
sbidoul
changed the title
There was a problem hiding this comment.
The change LGTM.
The module itself is a little strange. I see the intention, but e.g. when the name is updated, the name_customer isn't. (even though it wasn't different before, and the normal user doesn't see it)
Also when reading name customer I was thinking to replicate the customer name (partner_id.name). Wouldn't be name_report_overwrite a better choise and leave it empty if it is the same as the name attribute... only some ideas
|
I agree. I don't use this module I'm just here to get the branch green. /ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 893a9e2. Thanks a lot for contributing to OCA. ❤️ |
@CRogos thank you for your feedback. Yup, it might look strange, but it does a good job allowing to have separate description in timesheet reports for clients. It's extremely important eg case your devs log some technical details while client wants to see more business context in report. For the very same reason customer description doesn't change when the description itself is updated. |
Before this commit, the creation would fail when no 'name' value was provided.