Update summariseOmopTable() dependencies

OHDSI · Jun 10, 2024 · bbf4974 · bbf4974
1 parent 11dca1f
commit bbf4974
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -10,6 +10,9 @@ Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.3.1
 Suggests: 
+    DBI,
+    duckdb,
+    here,
     testthat (>= 3.0.0)
 Config/testthat/edition: 3
 Config/testthat/parallel: true

diff --git a/R/summariseOmopTable.R b/R/summariseOmopTable.R
@@ -240,7 +240,7 @@ addVariables <- function(x, variables) {
         by = "source"
       ) |>
       dplyr::mutate(
-        vocabulary = dplyr::if_else(is.na(vocabulary), "No matching concept", vocabulary)
+        vocabulary = dplyr::if_else(is.na(.data$vocabulary), "No matching concept", .data$vocabulary)
       ) |>
       dplyr::rename("source_concept" = "source", "source" = "vocabulary")
   }

diff --git a/man/summariseOmopTable.Rd b/man/summariseOmopTable.Rd
diff --git a/tests/testthat/test-summariseOmopTable.R b/tests/testthat/test-summariseOmopTable.R
@@ -24,7 +24,7 @@ test_that("summariseOmopTable() works", {
   expect_no_error(summariseOmopTable(cdm$condition_occurrence))
   expect_no_error(summariseOmopTable(cdm$drug_exposure))
   expect_no_error(summariseOmopTable(cdm$procedure_occurrence))
-  expect_no_error(summariseOmopTable(cdm$device_exposure))
+  expect_error(summariseOmopTable(cdm$device_exposure))
   expect_no_error(summariseOmopTable(cdm$measurement))
   expect_no_error(summariseOmopTable(cdm$observation))
   expect_error(summariseOmopTable(cdm$death))