fix and simplify support for CTEs in DDL statements for InterSystems #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #384 +/- ##
========================================
Coverage 79.74% 79.74%
========================================
Files 5 5
Lines 395 395
========================================
Hits 315 315
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schuemie
approved these changes
Apr 8, 2025
|
Thanks! Next time, would you mind targeting the develop branch? Main is for the latest released version only |
|
right, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the rewrite rules for DDL statements (including implicit through
SELECT .. INTO ..) that include CTEs. Previously, these were rewritten into separate statements to create temp tables, but ended up with malformed statements for some complexSELECT .. INTO ..statements produced by Achilles.We now found how we can stick to the existing CTEs by proper placement in the CTAS structure.
The change includes a few unit tests on sample queries in this case.