Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-ci: suppress author names; cancel earlier builds - v1 #9805

Closed
wants to merge 2 commits into from

Conversation

jasonish
Copy link
Member

  • Don't call out the new author names and emails in a PR comment, instead just
    add a comment that there may be an new author. The author names are still in
    the artifact though. Example: Test commit jasonish/suricata#192 (comment)

  • For builds.yml, cancel the previous job on a push to the same branch.

On a push of the same branch, cancel the previous running builds.yml
workflow.
The new author details will still be available in the artifact, we're
just not calling them out in a nighly visible pull request comment.
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #9805 (111e961) into master (2f4027c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9805      +/-   ##
==========================================
- Coverage   82.37%   82.36%   -0.01%     
==========================================
  Files         968      968              
  Lines      273866   273866              
==========================================
- Hits       225585   225583       -2     
- Misses      48281    48283       +2     
Flag Coverage Δ
fuzzcorpus 64.21% <ø> (ø)
suricata-verify 60.99% <ø> (+0.01%) ⬆️
unittests 62.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Nov 17, 2023
@victorjulien
Copy link
Member

Merged in #9829, thanks!

@jasonish jasonish deleted the ci-fixups/v1 branch March 14, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants