userguide: update tls not_after/not_before mentions - v1 #9814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tls fields not_after and not_before are actually logged as `notafter` and `notbefore`, but were documented with the underscore. Update the documentation, since updating the log format itself would be a breaking change. Task OISF#5494
jasonish
approved these changes
Nov 16, 2023
Agreed. One thing we could do is fix in the yaml, and then add code silently support the old names.. I think its just in the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9814 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 968 968
Lines 273866 273866
=======================================
+ Hits 225585 225589 +4
+ Misses 48281 48277 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Nov 16, 2023
This was referenced Nov 17, 2023
Closed
Closed
Merged
|
Merged in #9829, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tls fields not_after and not_before are actually logged as
notafterandnotbefore, but were documented with the underscore.Update the documentation, since updating the log format itself would be a breaking change.
Task #5494
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5494
Describe changes:
Thought of updating references in the yaml file, too, but this would mess up with implementation, from what I understood, and would mean taking longer to fix, so went with the simplest fix.