feat: add any pair capability to refinance strategy #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & targetDebt RefinanceParams
…4939/add-any-pair-to-simulator-order-planner
|
This pull request has been linked to Shortcut Story #14939: Add any pair to Simulator/Order Planner. |
robercano
suggested changes
Apr 2, 2024
sdk/simulator-service/src/strategies/refinance/RefinanceLendingToLending.ts
Outdated
Show resolved
Hide resolved
…4939/add-any-pair-to-simulator-order-planner
Base automatically changed from
jt/sc-14942/provide-swap-data-view-for-fe
to
dev
April 3, 2024 10:43
zerotucks
added a commit
that referenced
this pull request
Apr 3, 2024
- Add Swaps to Simulation output - Refactor `Simulation` -> `ISimulation` to align better with rest of the SDK - Refactor Swap related types from `swap-common` -> `sdk-common` to remove cyclic dependencies in simulation types Note: - `getSpotPrices` simplified to `getSpotPrice` in #153 TODO: - Write tests for simulation swaps (done in #153) - Update refinance strategy to handle swaps (current implementation is based on assumptions that no longer hold following ProtocolManager/Plugins/Pool work) (done in #153)
zerotucks
commented
Apr 3, 2024
sdk/simulator-service/src/implementation/simulator-engine/reducer/swapReducer.ts
Outdated
Show resolved
Hide resolved
robercano
suggested changes
Apr 3, 2024
robercano
approved these changes
Apr 5, 2024
zerotucks
deleted the
jt/sc-14939/add-any-pair-to-simulator-order-planner
branch
jakubswierczek
pushed a commit
that referenced
this pull request
Apr 8, 2024
- Add Swaps to Simulation output - Refactor `Simulation` -> `ISimulation` to align better with rest of the SDK - Refactor Swap related types from `swap-common` -> `sdk-common` to remove cyclic dependencies in simulation types Note: - `getSpotPrices` simplified to `getSpotPrice` in #153 TODO: - Write tests for simulation swaps (done in #153) - Update refinance strategy to handle swaps (current implementation is based on assumptions that no longer hold following ProtocolManager/Plugins/Pool work) (done in #153)
jakubswierczek
pushed a commit
that referenced
this pull request
Apr 8, 2024
- Reintroduce the two swaps to refinance strategy - Simplify spotPrice method on SwapManager and SwapProviders. Gets one price only. Calculates a derived spot price when the quote token is a token and not a currency symbol. - Calculate the borrowAmount on the target protocol when a debtSwap is required. Accounts for slippage and summer fees when determining how much to borrow to repay flashloan - Account for summer fees when getting quotes on swap steps - Add getSummerFee method to SwapManager (currently resolves only to 20 basis pts - will update shortly) TODO: - Add config and implement getSummerFee appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: