dkg: add customizable timeout #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users might DKG large clusters, containing high amounts of validators (like 2.5K). With large validator amounts, the DKG process needs either more time or more power (CPU, network bandwidth) to complete. Allow users to specify a custom timeout for the entire process, allowing large DKGs on normal-powered machines. Tested 2.5K validator DKGs locally with 0.relay.obol.tech, 10 minutes timeout: completed with no issues.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3130 +/- ##
==========================================
- Coverage 56.73% 56.73% -0.01%
==========================================
Files 208 208
Lines 29308 29317 +9
==========================================
+ Hits 16628 16632 +4
- Misses 10838 10845 +7
+ Partials 1842 1840 -2 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
approved these changes
Jun 11, 2024
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Jun 11, 2024
Users might DKG large clusters, containing high amounts of validators (like 2.5K). With large validator amounts, the DKG process needs either more time or more power (CPU, network bandwidth) to complete. Allow users to specify a custom timeout for the entire process, allowing large DKGs on normal-powered machines. Tested 2.5K validator DKGs locally with 0.relay.obol.tech, 10 minutes timeout: completed with no issues. category: feature ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might DKG large clusters, containing high amounts of validators (like 2.5K).
With large validator amounts, the DKG process needs either more time or more power (CPU, network bandwidth) to complete.
Allow users to specify a custom timeout for the entire process, allowing large DKGs on normal-powered machines.
Tested 2.5K validator DKGs locally with 0.relay.obol.tech, 10 minutes timeout: completed with no issues.
category: feature
ticket: none