chore: more size reduction #1405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadi-george
force-pushed
the
fg/size-reduction-6
branch
from
e993c17 to
6807604
Compare
fadi-george
force-pushed
the
fg/size-reduction-6
branch
3 times, most recently
from
be0b15f to
a609dfd
Compare
rename log
move DeliveryPlatformKindValue rename files remove "removeLegacySubscriptionOptions" logic
fadi-george
force-pushed
the
fg/size-reduction-6
branch
from
a609dfd to
a75d996
Compare
fadi-george
force-pushed
the
fg/size-reduction-6
branch
from
a75d996 to
cbe0e82
Compare
sherwinski
requested changes
Oct 29, 2025
|
|
||
| // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | ||
| const logDebugSpy = vi.spyOn(Log, '_debug'); | ||
| const logDebugSpy = vi.spyOn(Log, 'debug'); |
Contributor
There was a problem hiding this comment.
When I run the test suite locally it fails on this line:
TypeError: Cannot redefine property: mock
| new Error(`"${argName}" is reserved`); | ||
|
|
||
| export const UnknownOpError = (op: { _name?: string } | { _name?: string }[]) => | ||
| new Error(`Unknown op(s):${op}`); |
Contributor
There was a problem hiding this comment.
Suggested change
| new Error(`Unknown op(s):${op}`); | |
| new Error(`Unknown op(s): ${JSON.stringify(op)}`); |
Contributor
There was a problem hiding this comment.
why rename this from Log.ts to log.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Details
models/Subscriptionin favor of an interfaceSystems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is