Skip to content

chore: more size reduction #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: fg/adjust-events
Choose a base branch
from
Open

chore: more size reduction #1405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad0c99f
break up log
fadi-george Oct 16, 2025
2923910
more clean up of types usage
fadi-george Oct 16, 2025
6148330
change subscription to interface
fadi-george Oct 24, 2025
4d43c14
add more prefix usages
fadi-george Oct 24, 2025
a7a8722
add unknown op error
fadi-george Oct 24, 2025
cbe0e82
simplify get language code
fadi-george Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions __test__/support/environment/TestEnvironmentHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ export const setupSubModelStore = async ({
onesignalId,
});
if (web_auth) {
pushModel.web_auth = web_auth;
pushModel._web_auth = web_auth;
}
if (web_p256) {
pushModel.web_p256 = web_p256;
pushModel._web_p256 = web_p256;
}
await setPushToken(pushModel.token);
await setPushToken(pushModel._token);
OneSignal._coreDirector._subscriptionModelStore._replaceAll(
[pushModel],
ModelChangeTags._NoPropogate,
Expand Down
4 changes: 2 additions & 2 deletions __test__/support/helpers/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ export const setupSubscriptionModel = async (
token: string | undefined,
) => {
const subscriptionModel = new SubscriptionModel();
subscriptionModel.id = id || '';
subscriptionModel.token = token || '';
subscriptionModel._id = id || '';
subscriptionModel._token = token || '';
OneSignal._coreDirector._subscriptionModelStore._replaceAll(
[subscriptionModel],
ModelChangeTags._NoPropogate,
Expand Down
Loading
Loading