[php-symfony] fix sequencial escape when validating a class type #22906
+25
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the api controller, validation is done using doubles quotes to check class type. This can lead to errors by interpreting a part of the string as an escaped character.
For exemple, if it compares class name like this one "\My\Namespace\Xcase", "\Xca" will be interpreted as an hexadecimal character and the validator will not match the class.
See https://www.php.net/manual/en/regexp.reference.escape.php for more informations.
Using single quotes fix the problem as strings are not interpreted as escaped ones.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon
Summary by cubic
Switch Assert\Type strings to single quotes in the PHP Symfony generator to prevent PHP escape-sequence interpretation during class type validation. Regenerated Symfony samples; added a missing return type in the test AppKernel.
Written for commit c57b655. Summary will update on new commits.