Skip to content

[php-symfony] fix sequencial escape when validating a class type #22906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fl0ux wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[php-symfony] fix sequencial escape when validating a class type #22906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328f969
[php-symfony] do not interpret sequential escape
Fl0ux Feb 4, 2026
2ea5f03
chore: update samples
Fl0ux Feb 4, 2026
c57b655
refactor: add missing return type
Fl0ux Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/php-symfony/api_input_validation.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
$asserts[] = new Assert\Type("\{{modelPackage}}\{{dataType}}");
{{/isEnumRef}}
{{^isEnumRef}}
$asserts[] = new Assert\Type("{{dataType}}");
$asserts[] = new Assert\Type('{{dataType}}');
{{^isPrimitiveType}}
$asserts[] = new Assert\Valid();
{{/isPrimitiveType}}
Expand Down
26 changes: 13 additions & 13 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function addPetAction(Request $request)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\Pet");
$asserts[] = new Assert\Type('OpenAPI\Server\Model\Pet');
$asserts[] = new Assert\Valid();
$response = $this->validate($pet, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -170,13 +170,13 @@ public function deletePetAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
}
$asserts = [];
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($apiKey, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -250,7 +250,7 @@ public function downloadFileAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -496,7 +496,7 @@ public function getPetByIdAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -573,7 +573,7 @@ public function petAgeAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -646,7 +646,7 @@ public function petAvailableForSaleAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -731,7 +731,7 @@ public function updatePetAction(Request $request)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\Pet");
$asserts[] = new Assert\Type('OpenAPI\Server\Model\Pet');
$asserts[] = new Assert\Valid();
$response = $this->validate($pet, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -808,19 +808,19 @@ public function updatePetWithFormAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
}
$asserts = [];
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($name, $asserts);
if ($response instanceof Response) {
return $response;
}
$asserts = [];
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($status, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -900,13 +900,13 @@ public function uploadFileAction(Request $request, $petId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$response = $this->validate($petId, $asserts);
if ($response instanceof Response) {
return $response;
}
$asserts = [];
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($additionalMetadata, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down
6 changes: 3 additions & 3 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function deleteOrderAction(Request $request, $orderId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($orderId, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -212,7 +212,7 @@ public function getOrderByIdAction(Request $request, $orderId)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("int");
$asserts[] = new Assert\Type('int');
$asserts[] = new Assert\GreaterThanOrEqual(1);
$asserts[] = new Assert\LessThanOrEqual(5);
$response = $this->validate($orderId, $asserts);
Expand Down Expand Up @@ -298,7 +298,7 @@ public function placeOrderAction(Request $request)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\Order");
$asserts[] = new Assert\Type('OpenAPI\Server\Model\Order');
$asserts[] = new Assert\Valid();
$response = $this->validate($order, $asserts);
if ($response instanceof Response) {
Expand Down
14 changes: 7 additions & 7 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/UserController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function createUserAction(Request $request)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\User");
$asserts[] = new Assert\Type('OpenAPI\Server\Model\User');
$asserts[] = new Assert\Valid();
$response = $this->validate($user, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -316,7 +316,7 @@ public function deleteUserAction(Request $request, $username)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($username, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -391,7 +391,7 @@ public function getUserByNameAction(Request $request, $username)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($username, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -469,15 +469,15 @@ public function loginUserAction(Request $request)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$asserts[] = new Assert\Regex("/^[a-zA-Z0-9]+[a-zA-Z0-9\\.\\-_]*[a-zA-Z0-9]+$/");
$response = $this->validate($username, $asserts);
if ($response instanceof Response) {
return $response;
}
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($password, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -609,14 +609,14 @@ public function updateUserAction(Request $request, $username)
// Validate the input values
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("string");
$asserts[] = new Assert\Type('string');
$response = $this->validate($username, $asserts);
if ($response instanceof Response) {
return $response;
}
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\User");
$asserts[] = new Assert\Type('OpenAPI\Server\Model\User');
$asserts[] = new Assert\Valid();
$response = $this->validate($user, $asserts);
if ($response instanceof Response) {
Expand Down
2 changes: 1 addition & 1 deletion samples/server/petstore/php-symfony/SymfonyBundle-php/Tests/AppKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function registerBundles(): iterable
* @inheritDoc
* @throws \Exception
*/
public function registerContainerConfiguration(LoaderInterface $loader)
public function registerContainerConfiguration(LoaderInterface $loader): void
{
$loader->load(__DIR__.'/test_config.yaml');
}
Expand Down