Overheidnl/theme #277
Open
Overheidnl/theme #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remko48
requested changes
Jun 19, 2023
|
|
||
| /* Theme Design Tokens */ | ||
| /* TODO: Load themes on-demand */ | ||
| @import "../../node_modules/@nl-design-system-unstable/overheidnl-design-tokens/dist/index.css"; |
Collaborator
There was a problem hiding this comment.
The development server cannot start with this line active.
| @@ -0,0 +1,275 @@ | |||
| /* Generics global */ | |||
Collaborator
There was a problem hiding this comment.
I think there are still tokens missing or not being set properly. The buttons are missing padding or a white text.
Collaborator
Author
There was a problem hiding this comment.
The theme is not loading in because the overheidnl package is not live yet. You need to use npm link on this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.