Wait 5s after UI robot types in a config file #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkeylurkey
requested review from
mrglavas,
TrevCraw,
aparnamichael and
vaisakhkannan
|
Let's wait and see how things go with a fix for redhat-developer/lsp4ij#577 |
turkeylurkey
force-pushed
the
issue-972a
branch
from
b0e6ff9
to
94f0d33
Compare
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
turkeylurkey
force-pushed
the
issue-972a
branch
from
94f0d33
to
1dac83f
Compare
mrglavas
previously approved these changes
Oct 30, 2024
TrevCraw
reviewed
Oct 30, 2024
|
To be clear, we believe this PR combined with this fix in LSP4IJ - redhat-developer/lsp4ij#587 - will ultimately resolve the server.env test failure as reported in #945. |
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
|
Check in tomorrow! 🕥 |
|
10/31 Linux failure due to Liberty hung error. |
TrevCraw
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic fails to appear in the editor because the robot clicks on the editor tab immediately after typing the value (after the equals. sign). A bug or feature in IntelliJ makes it give up on the unrendered diagnostic when the user turns attention somewhere else.
Here is how I decided on the amount of time to wait. It may take 1s so I doubled it. On Mac it might be slow so I doubled it again and rounded up.
This fix relies on using the LCLS 2.2-SNAPSHOT. I do not include it here because someone else has been testing this and will make a separate pull request. Here is the test result when you do use 2.2-snapshot:
Fixes #945