Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notification for PR reviews #185

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

crecine
Copy link
Contributor

@crecine crecine commented Mar 18, 2024

Summary

Sending review information when a review is submitted

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@crecine crecine requested a review from johnjasa March 18, 2024 23:20
- name: Send Email on PR Review
uses: ./actions/.github/actions/send_email
with:
username: ${{ secrets.EMAIL_USERNAME }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the PR submitter's email? Or is it the person who starts the job.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither, it is the email address of the mail server that sends the notifications

@crecine crecine enabled auto-merge March 20, 2024 20:40
@crecine crecine added this pull request to the merge queue Mar 20, 2024
Merged via the queue into OpenMDAO:main with commit 1d78783 Mar 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants