Conversation
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
PaulaSp3
commented
Aug 11, 2025
awirb
requested changes
Aug 12, 2025
PaulaSp3
commented
Aug 12, 2025
PaulaSp3
commented
Aug 12, 2025
PaulaSp3
commented
Aug 12, 2025
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
f7d0138 to
d82f478
Compare
fso42
requested changes
Aug 14, 2025
fso42
changed the title
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
617663f to
8f8137a
Compare
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
eade224 to
bd6d031
Compare
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
5bb1d34 to
b3b7f70
Compare
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
ee06344 to
9118cc4
Compare
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
9118cc4 to
e3eb671
Compare
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
e3eb671 to
79bed77
Compare
Contributor
❌ 5 blocking issues (5 total)
@qltysh one-click actions:
|
awirb
reviewed
Nov 17, 2025
awirb
approved these changes
Nov 18, 2025
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
79dfa85 to
af21d82
Compare
Contributor
|
Diff Coverage: The code coverage on the diff in this pull request is 52.3%. Total Coverage: This PR will decrease coverage by 0.25%. File Coverage Changes
🛟 Help
|
fso42
approved these changes
Nov 18, 2025
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
af21d82 to
3bbab65
Compare
PaulaSp3
force-pushed
the
PS_hydrograph
branch
from
3bbab65 to
a3164a3
Compare
first try to get source in different time steps first try for particles with initial velocity hydrographs works with csv table Array containing z - location of particles is updated with hydrograph particles comment FSO: move specific hydrograph functions in a separate debris file adapt tests add tests for new functions add check for requirements of hydrograph csv file update velocity magnitude check if existing particles are withon hydrograph polygon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first try with hydrograph as input (additionally to REL-area)
a polygon of the area and a csv-table (containing timesteps in first column, thickness values in the second column, and optionally velocity values in the third column) need to be provided in
Inputs/HYDRin defined time steps additional particles are initialized (similar as REL-area):
there are still many open questions and ideas for improvements (see sub issues in DebrisFrame Issue #13)
doc, a standard setup and standard tests are still missing (Add example setup for hydrograph input DebrisFrame#27).