[#43] Update
clippy
5 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 5 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 86 in rpg_tools_rendering/src/rendering/equipment/footwear.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> rpg_tools_rendering/src/rendering/equipment/footwear.rs:86:39
|
86 | renderer.render_polygon(&polygon, &options);
| ^^^^^^^^ help: change this to: `options`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 20 in macro_ui/src/utils.rs
github-actions / clippy
this `if let` can be collapsed into the outer `if let`
warning: this `if let` can be collapsed into the outer `if let`
--> macro_ui/src/utils.rs:18:29
|
18 | / ... if let Type::Path(type_path) = t {
19 | | ... return type_path.path.segments.first().map(|s| s.ident.clone());
20 | | ... }
| |_______________________^
|
help: the outer pattern can be modified to include the inner pattern
--> macro_ui/src/utils.rs:17:59
|
17 | if let Some(GenericArgument::Type(t)) = args.args.first() {
| ^ replace this binding
18 | if let Type::Path(type_path) = t {
| ^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default
Check warning on line 127 in rpg_tools_core/src/ui/editor.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> rpg_tools_core/src/ui/editor.rs:127:13
|
127 | &vec!["true".to_string(), "false".to_string()],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["true".to_string(), "false".to_string()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
Check warning on line 114 in rpg_tools_core/src/ui/editor.rs
github-actions / clippy
useless use of `vec!`
warning: useless use of `vec!`
--> rpg_tools_core/src/ui/editor.rs:114:13
|
114 | &vec!["true".to_string(), "false".to_string()],
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["true".to_string(), "false".to_string()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
Check warning on line 20 in macro_ui/src/utils.rs
github-actions / clippy
this `if let` can be collapsed into the outer `if let`
warning: this `if let` can be collapsed into the outer `if let`
--> macro_ui/src/utils.rs:18:29
|
18 | / ... if let Type::Path(type_path) = t {
19 | | ... return type_path.path.segments.first().map(|s| s.ident.clone());
20 | | ... }
| |_______________________^
|
help: the outer pattern can be modified to include the inner pattern
--> macro_ui/src/utils.rs:17:59
|
17 | if let Some(GenericArgument::Type(t)) = args.args.first() {
| ^ replace this binding
18 | if let Type::Path(type_path) = t {
| ^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default