Subtitles Placement Settings #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added UI elements to the Player prefab to allow adjustment of subtitle parameters (height, font size, width) - Added new UI elements to GameManager and SceneController for persistence across scenes - Added translations for new UI elements - Changed how width was handled in NarrationManager to ensure update with new subtitle width setting - Added subtitles-placement APK for testing
- Width updated to have default value 640, with a range of 250 (from initially 700 with range of 200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added settings in the UI menu for adjusting subtitles y-axis placement, container width and font size