Skip to content

Subtitles Placement Settings #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mireille-T wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Subtitles Placement Settings #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df98f41
Added subtitles settings
Mireille-T Oct 29, 2024
663894f
Update default subtitle placement values
Mireille-T Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion POINT-VR-Chapter-1/Assets/POINT/Audio/Narration/NarrationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ public GameManager.Language SubtitlesLanguage
}
}

private float maxSubtitleWidth;
public float MaxSubtitleWidth
{
set
{
maxSubtitleWidth = value;
}
}

// Cache
private TMP_Text subtitleText = null;
private Image subtitleBackground = null;
Expand Down Expand Up @@ -113,7 +122,7 @@ private void UpdateSubtitleUI()
subtitleText.font = currentFont;
subtitleObject.SetActive(true);
subtitleText.text = output;
subtitleBackground.rectTransform.sizeDelta = new Vector2(subtitleText.preferredWidth, subtitleText.preferredHeight);
subtitleBackground.rectTransform.sizeDelta = new Vector2(Mathf.Min(subtitleText.preferredWidth, maxSubtitleWidth), subtitleText.preferredHeight);
}
else
{
Expand Down
6 changes: 6 additions & 0 deletions POINT-VR-Chapter-1/Assets/POINT/InputAssets/GameManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ public struct PlayerData
public bool isControllerHighlighted;
public Language language;
public Language subtitleLanguage;
public float subtitleHeightValue;
public float subtitleSizeValue;
public float subtitleWidthValue;
}
public static GameManager Instance { get; private set; }
public enum Language { Disabled = 0, English = 1, Spanish = 2, French = 3, Mandarin = 4, Japanese = 5, Hindi = 6, Arabic = 7, Bengali = 8, Russian = 9, Portuguese = 10, Malay = 11, Urdu = 12, Telugu = 13, Korean = 14 };
Expand All @@ -31,6 +34,9 @@ private void Awake()
data.isControllerHighlighted = true;
data.language = Language.English;
data.subtitleLanguage = Language.English;
data.subtitleHeightValue = 0.5f;
data.subtitleSizeValue = 0.5f;
data.subtitleWidthValue = 0.5f;
}
if (Instance != this)
{
Expand Down
Loading