Skip to content

Bugfix arrows audio #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RatchevD wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bugfix arrows audio #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a9b0e3
Reworked Arrow Task to Fix Bug
RatchevD Mar 31, 2025
60a04b1
Removed Scripts From Arrows
RatchevD Mar 31, 2025
96eff7a
Added APK file
RatchevD Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions POINT-VR-Chapter-1/Assets/POINT/Scenes/Conference Demos/ConfDemo_part1_one-mass-y.unity
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.size
value: 2
value: 1
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand Down Expand Up @@ -663,7 +663,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.size
value: 2
value: 1
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand All @@ -683,7 +683,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.data[1].m_CallState
value: 2
value: 0
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand All @@ -693,7 +693,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.data[1].m_MethodName
value: CheckArrowTask
value:
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand Down Expand Up @@ -1928,7 +1928,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.size
value: 2
value: 1
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand Down Expand Up @@ -2174,7 +2174,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.size
value: 2
value: 1
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand Down Expand Up @@ -2314,7 +2314,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.size
value: 2
value: 1
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand Down Expand Up @@ -2719,7 +2719,7 @@ PrefabInstance:
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
propertyPath: onCast.m_PersistentCalls.m_Calls.Array.size
value: 2
value: 1
objectReference: {fileID: 0}
- target: {fileID: 1128561483501416258, guid: b67bcc037869c8245a2348ffee62f596,
type: 3}
Expand Down
11 changes: 8 additions & 3 deletions POINT-VR-Chapter-1/Assets/POINT/Scenes/Conference Demos/ConfDemo_part1_one_mass_y_manager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,21 +116,26 @@ private IEnumerator StartScene()
yield return new WaitForSeconds(2);
player.GetComponent<NarrationManager>().PlayClipWithSubtitles("Chapter1Scene2\\3_direction_of_curvature_arrow_5");
yield return new WaitForSeconds(6.1f);
// wait for player to reach correct arrow orientation
yield return new WaitUntil(() => CheckArrowTask());
StartCoroutine(StartScenePart2());
}

private void ArrowTask()
{
setOfDirectionalArrows.SetActive(true); // spawn six directional arrows
}

public void CheckArrowTask()
public bool CheckArrowTask()
{
foreach (DirectionalArrow directionalArrow in directionalArrows)
{
if (!directionalArrow.IsCorrect) return;
if (!directionalArrow.IsCorrect) {
return false;
}
}

StartCoroutine(StartScenePart2());
return true;
}

private IEnumerator StartScenePart2()
Expand Down
Binary file added POINT-VR-Chapter-1/Builds/ArrowAudioTest.apk
View file
Open in desktop
Binary file not shown.