added codecov code for showing statistics #2871
Conversation
|
Warning Rate limit exceeded@VanshikaSabharwal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 37 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(7 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/pull-request.yml
192-192: job "run-tests" needs job "check-eslint-disable" which does not exist in this workflow
(job-needs)
192-192: job "run-tests" needs job "check-code-coverage-disable" which does not exist in this workflow
(job-needs)
🪛 yamllint (1.35.1)
.github/workflows/pull-request.yml
[error] 308-308: too many blank lines
(1 > 0) (empty-lines)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyse Code With CodeQL (typescript)
🔇 Additional comments (4)
.github/workflows/pull-request.yml (4)
30-31: LGTM! Improved readability with consistent spacing.
89-89: LGTM! Consistent spacing maintained.
130-191: LGTM! Well-organized sensitive files list.The sensitive files list is now better organized with consistent formatting and clear structure.
214-218: LGTM! Good practice setting minimum coverage threshold.Setting a minimum coverage threshold of 95.0% helps maintain high code quality standards.
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
varshith257
added
the
ignore-sensitive-files-pr
|
The |
|
Code coverage statistics aren't shown in the PR either. |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
vitest.config.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyse Code With CodeQL (typescript)
|
Tip For best results, initiate chat on the files or code changes. @VanshikaSabharwal The error occurs because the coverage report isn't being generated. While your Please modify the "run_tests" script in your {
"run_tests": "vitest --coverage"
}This will ensure that Vitest generates the coverage reports, including the lcov.info file in the ./coverage directory. 🔗 Analysis chain🏁 Scripts executedThe following scripts were executed for the analysis: Script: Length of output: 2918 ✏️ Learnings added
|
|
Tip For best results, initiate chat on the files or code changes. @VanshikaSabharwal I see that the
"run_tests": "vitest"to: "run_tests": "vitest --coverage"This change is necessary to generate the coverage reports. Once you make this change, the workflow should be able to find the lcov.info file and upload it to Codecov. 🔗 Analysis chain🏁 Scripts executedThe following scripts were executed for the analysis: Script: Length of output: 2756 |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
yes |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@palisadoes Is everything fine now? |
No, the sensitive files check isn't running when the label is removed. That whole section needs to be restored to what is was before there must be no diffs |
|
It's better if you make edits to the raw file (click on the |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(8 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/pull-request.yml
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 313-313: too many blank lines
(1 > 0) (empty-lines)
🪛 actionlint (1.7.4)
.github/workflows/pull-request.yml
208-208: shellcheck reported issue in this script: SC2086:info:2:11: Double quote to prevent globbing and word splitting
(shellcheck)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Run tests for talawa api
- GitHub Check: Analyse Code With CodeQL (typescript)
🔇 Additional comments (9)
.github/workflows/pull-request.yml (9)
30-31: LGTM! Improved readability.The added blank line after the exit command improves readability without affecting functionality.
89-89: LGTM! Improved readability.The added blank line after the script execution improves readability without affecting functionality.
101-101: LGTM! Improved job separation.The added blank lines improve job separation and readability without affecting functionality.
Also applies to: 112-112
195-197: LGTM! Proper job configuration.The job dependencies and environment variable setup look correct.
211-218: LGTM! Proper Codecov configuration.The Codecov upload step is well-configured with proper token handling and error settings.
229-229: LGTM! Improved readability.The added blank line improves readability without affecting functionality.
313-313: Remove extra blank lines at the end of the file.yamllint reports too many blank lines at the end of the file.
- name: Run docstring compliance check run: | source venv/bin/activate python .github/workflows/scripts/check_docstrings.py --directories .github -🧰 Tools
🪛 yamllint (1.35.1)
[error] 313-313: too many blank lines
(1 > 0) (empty-lines)
207-210:⚠️ Potential issueFix shell script quoting.
The container ID command should use quotes to prevent word splitting and globbing issues.
- docker cp $CONTAINER_ID:/home/talawa/api/coverage ./coverage + docker cp "$CONTAINER_ID:/home/talawa/api/coverage" ./coverage⛔ Skipped due to learnings
Learnt from: VanshikaSabharwal PR: PalisadoesFoundation/talawa-api#0 File: :0-0 Timestamp: 2025-01-20T07:33:55.198Z Learning: When running tests with coverage in a Docker container, the coverage files need to be explicitly copied out of the container using `docker cp` or mounted via volumes to make them available to the host system for coverage reporting tools.🧰 Tools
🪛 actionlint (1.7.4)
208-208: shellcheck reported issue in this script: SC2086:info:2:11: Double quote to prevent globbing and word splitting
(shellcheck)
219-223: 🧹 Nitpick (assertive)Consider increasing the minimum code coverage threshold.
The current threshold of 39.0% is quite low. Consider gradually increasing this threshold to encourage better test coverage. A common target is 80% or higher.
- min_coverage: 39.0 + min_coverage: 80.0Likely invalid or redundant comment.
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
@palisadoes I have reverted the changes. |
palisadoes
merged commit 1a88e15
into
PalisadoesFoundation:develop-postgres
|
Thanks |
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #2854
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Chores