fix: S3 bucket name used from the application configuration instead of infered from CDN_URL #10661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f infered from CDN_URL
mattkrick
reviewed
Jan 21, 2025
| } catch (e) { | ||
| if (e instanceof Error && e.name === 'NotFound') return false | ||
| else { | ||
| Logger.log(`Invalid error ${(e as Error).name}`) | ||
| throw new Error(`Can't verify if the object ${Key} is in the S3 bucket ${this.bucket}`) |
There was a problem hiding this comment.
-1 this will be a breaking change, it may work, but IIRC there was some case where s3 would error, but it would still exist. Since we're getting off S3 anyways, I say we keep the result the same (return true if error) but let's leave the log in so we can see under what case that's true
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
9 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
preDeploy wasn't uploading template assets to the AWS S3 bucket.
Testing scenarios
Clean-up the local-development folder of our AWS S3 bucket and run preDeploy. It should push all files, including the templates.