Skip to content

error message for unknown primitive type #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jannik-Hm merged 2 commits into from
Nov 21, 2025
Merged

error message for unknown primitive type #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d7f04
added error message for unknown primitive type
Jannik-Hm Nov 21, 2025
3b491b3
added error for invalid ModelReader conf
Jannik-Hm Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,15 @@ func GetModel(conf ModelReaderConf, desiredSize MeshTypes.Vector) (*MeshTypes.Me
default:
return nil, fmt.Errorf("unknown model type %s", filetype)
}
} else if conf.PrimitiveType != "Undefined" && Primitives.Primitives[conf.PrimitiveType] != nil {
} else if conf.PrimitiveType != "Undefined" {
if Primitives.Primitives[conf.PrimitiveType] == nil {
return nil, fmt.Errorf("unknown primitive type %s", conf.PrimitiveType)
}
tempMesh := Primitives.Primitives[conf.PrimitiveType].Copy()
mesh = &tempMesh
mesh.ScaleToDimensions(&desiredSize)
} else {
return nil, fmt.Errorf("invalid ModelReader config")
}

return mesh, nil
Expand Down
Loading