Skip to content

Comments

Breaking Change: ptr to copy transition#19

Merged
Jannik-Hm merged 3 commits intomainfrom
ptr-to-direct-transition
Feb 20, 2026
Merged

Breaking Change: ptr to copy transition#19
Jannik-Hm merged 3 commits intomainfrom
ptr-to-direct-transition

Conversation

@Jannik-Hm
Copy link
Member

@Jannik-Hm Jannik-Hm commented Feb 20, 2026

memory optimization as ptr lookups can be more costly

@Jannik-Hm Jannik-Hm self-assigned this Feb 20, 2026
@Jannik-Hm Jannik-Hm added the enhancement New feature or request label Feb 20, 2026
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Test Coverage Report 📊

File Function Coverage
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:10: IdentityMatrix 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:19: Mul 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:40: MulScalar 0.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:49: MulPosition 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:56: MulDirection 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:11: AddTriangle 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:15: Copy 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:21: Add 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:30: RotateAndTranslate 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:50: CalculateBoundingBox 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:75: Scale 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:94: ScaleToDimensions 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/triangle.go:9: Normal 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/triangle.go:15: Copy 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:32: DivScalar 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:36: Add 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:40: Sub 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:44: Cross 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:51: Normalize 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:56: ToVertex 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:63: Min 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:71: Max 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:79: Mult 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:87: Div 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vertex.go:8: Copy 100.0%
total: (statements) 99.0%

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Test Coverage Report 📊

File Function Coverage
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:10: IdentityMatrix 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:19: Mul 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:40: MulScalar 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:49: MulPosition 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/matrix.go:56: MulDirection 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:11: AddTriangle 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:15: Copy 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:21: Add 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:30: RotateAndTranslate 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:50: CalculateBoundingBox 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:75: Scale 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/mesh.go:94: ScaleToDimensions 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/triangle.go:9: Normal 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/triangle.go:15: Copy 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:32: DivScalar 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:36: Add 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:40: Sub 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:44: Cross 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:51: Normalize 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:56: ToVertex 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:63: Min 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:71: Max 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:79: Mult 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vector.go:87: Div 100.0%
github.com/Patch2PDF/GDTF-Mesh-Reader/pkg/MeshTypes/vertex.go:8: Copy 100.0%
total: (statements) 100.0%

@Jannik-Hm Jannik-Hm merged commit 9e7d255 into main Feb 20, 2026
7 checks passed
@Jannik-Hm Jannik-Hm deleted the ptr-to-direct-transition branch February 20, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Jannik-Hm Jannik-Hm

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jannik-Hm